Avoid OOM errors when event traffic is high #1376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert to attaching the IsolateRef instead of the Isolate to the postEvent and registerExtension events. The Isolate is much larger and was causing systems to run out of memory when event traffic was high like in Flutter where they are sent on every animation frame. See: flutter/flutter#87100
bkonyi
approved these changes
Aug 3, 2021
Collaborator
bkonyi
left a comment
bkonyi
left a comment
There was a problem hiding this comment.
LGTM! In general, we should be sending reference types for high-traffic events, so this is perfect. Thanks!
Contributor
|
Merging this so we can deliver the fix to flutter soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert to attaching the IsolateRef instead of the Isolate to the postEvent
and registerExtension events. The Isolate is much larger and was causing
systems to run out of memory when event traffic is high like in Flutter
where they are sent on every animation frame.
See: flutter/flutter#87100